DOMA-3959: Patch Dicer (keystone -> graphql-upload -> busboy -> dicer) #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create patches for @keystonejs/app-graphql, @keystonejs/keystone - learn how to support patches using yarn - write correct resolutions - do minor updates
|
Kudos, SonarCloud Quality Gate passed!
|
sitozzz
approved these changes
Sep 4, 2023
toplenboren
changed the title
pahaz
approved these changes
Sep 6, 2023
pahaz
approved these changes
Sep 6, 2023
pahaz
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We are using keystone-v5 in our open source condominium management software.
We recently encountered a bug, when keystone crashes while processing multipart requests. It seems that the issue might be related to the old versions of the dicer and busboy packages.
Our issue looks awfully similar to this security flaw: GHSA-wm7h-9275-46v2 and has already been fixed in the apollo-graphql v15.0.0 release.
Considering this, we decided to bump the dependency from 11.0.0 to version 15.0.2.
Solution:
This PR bumps grapnql-upload in whole project to 15.0.2, which has GHSA-wm7h-9275-46v2 fixed.
Implementation details
We do this using internal yarn functionality. Patches should be applied when you run
yarnhttps://yarnpkg.com/cli/patchgraphql-uploadversion in rootpackage.jsongraphql-upload@15.*.*in Keystone:Caveats:
KS version is fixed at 19.3.4
GQL-upload is fixed at 15.0.2
This is going to be reverted if:
-- We go KS6
-- Bump gql upload to 15 keystonejs/keystone-5#415 is merged to KS5